Skip to content

Avoid unnecessary use of array.forEach in JS. NFC #24895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid unnecessary use of array.forEach in JS. NFC #24895

wants to merge 1 commit into from
+16 −19

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Aug 8, 2025

In both these cases the code is smaller and simpler.

@sbc100 sbc100 requested a review from kripken August 8, 2025 23:34
@sbc100 sbc100 changed the title Avoid unnecessary if of array.forEach in JS. NFC Avoid unnecessary use of array.forEach in JS. NFC Aug 8, 2025
@sbc100
Avoid unnecessary if of array.forEach in JS. NFC
4793205 
In both these cases the code is smaller and simpler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @kripken